diff --git a/app/src/main/java/net/nullsum/audinaut/adapter/SectionAdapter.java b/app/src/main/java/net/nullsum/audinaut/adapter/SectionAdapter.java index 6b97749..d9c716a 100644 --- a/app/src/main/java/net/nullsum/audinaut/adapter/SectionAdapter.java +++ b/app/src/main/java/net/nullsum/audinaut/adapter/SectionAdapter.java @@ -315,8 +315,7 @@ public abstract class SectionAdapter extends RecyclerView.Adapter getSelected() { - List selected = new ArrayList<>(); - selected.addAll(this.selected); + List selected = new ArrayList<>(this.selected); return selected; } diff --git a/app/src/main/java/net/nullsum/audinaut/fragments/DownloadFragment.java b/app/src/main/java/net/nullsum/audinaut/fragments/DownloadFragment.java index 9046ac7..1ae3976 100644 --- a/app/src/main/java/net/nullsum/audinaut/fragments/DownloadFragment.java +++ b/app/src/main/java/net/nullsum/audinaut/fragments/DownloadFragment.java @@ -97,8 +97,7 @@ public class DownloadFragment extends SelectRecyclerFragment imple return new ArrayList<>(); } - List songList = new ArrayList<>(); - songList.addAll(downloadService.getBackgroundDownloads()); + List songList = new ArrayList<>(downloadService.getBackgroundDownloads()); currentRevision = downloadService.getDownloadListUpdateRevision(); return songList; } diff --git a/app/src/main/java/net/nullsum/audinaut/fragments/SelectArtistFragment.java b/app/src/main/java/net/nullsum/audinaut/fragments/SelectArtistFragment.java index 9c5e845..c60090a 100644 --- a/app/src/main/java/net/nullsum/audinaut/fragments/SelectArtistFragment.java +++ b/app/src/main/java/net/nullsum/audinaut/fragments/SelectArtistFragment.java @@ -177,7 +177,6 @@ public class SelectArtistFragment extends SelectRecyclerFragment i items.addAll(entries); } else { List artists = new ArrayList<>(); - items = new ArrayList<>(); MusicDirectory dir = musicService.getMusicDirectory(groupId, groupName, refresh, context, listener); for (Entry entry : dir.getChildren(true, false)) { Artist artist = new Artist(); @@ -189,7 +188,7 @@ public class SelectArtistFragment extends SelectRecyclerFragment i Indexes indexes = new Indexes(); //indexes.setArtists = artists; indexes.sortChildren(context); - items.addAll(indexes.getArtists()); + items = new ArrayList<>(indexes.getArtists()); entries = dir.getChildren(false, true); items.addAll(entries); diff --git a/app/src/main/java/net/nullsum/audinaut/fragments/SubsonicFragment.java b/app/src/main/java/net/nullsum/audinaut/fragments/SubsonicFragment.java index 7734282..21a1880 100644 --- a/app/src/main/java/net/nullsum/audinaut/fragments/SubsonicFragment.java +++ b/app/src/main/java/net/nullsum/audinaut/fragments/SubsonicFragment.java @@ -836,8 +836,7 @@ public class SubsonicFragment extends Fragment implements SwipeRefreshLayout.OnR @Override protected List doInBackground() throws Throwable { MusicService musicService = MusicServiceFactory.getMusicService(context); - List playlists = new ArrayList<>(); - playlists.addAll(musicService.getPlaylists(false, context, this)); + List playlists = new ArrayList<>(musicService.getPlaylists(false, context, this)); // Iterate through and remove all non owned public playlists Iterator it = playlists.iterator(); diff --git a/app/src/main/java/net/nullsum/audinaut/service/CachedMusicService.java b/app/src/main/java/net/nullsum/audinaut/service/CachedMusicService.java index c54b8fd..a06e1eb 100644 --- a/app/src/main/java/net/nullsum/audinaut/service/CachedMusicService.java +++ b/app/src/main/java/net/nullsum/audinaut/service/CachedMusicService.java @@ -659,8 +659,7 @@ public class CachedMusicService implements MusicService { private void deleteRemovedEntries(Context context, MusicDirectory dir, MusicDirectory cached) { if (cached != null) { - List oldList = new ArrayList<>(); - oldList.addAll(cached.getChildren()); + List oldList = new ArrayList<>(cached.getChildren()); oldList.removeAll(dir.getChildren()); // Anything remaining has been removed from server