PublicMirrors/Starship
1
0
Fork 0
mirror of https://github.com/HarbourMasters/Starship.git synced 2025-02-09 03:37:49 +03:00
Code Issues Actions Packages Projects Releases 1 Wiki Activity

AVOID_UB in fox_message

Browse Source
This commit is contained in:
Alejandro Javier Asenjo Nitti 2024-04-27 14:33:59 -03:00
parent 5056a6ef31
commit 25d8938483
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/engine/fox_message.c
View File

@ -62,12 +62,15 @@ bool Message_DisplayText(Gfx** gfxPtr, u16* msgPtr, s32 xPos, s32 yPos, s32 len)
s32 xChar = xPos; s32 xChar = xPos;
s32 yChar = yPos; s32 yChar = yPos;
s32 i; s32 i;
s32 print; bool print;
gDPSetPrimColor((*gfxPtr)++, 0x00, 0x00, 255, 255, 255, 255); gDPSetPrimColor((*gfxPtr)++, 0x00, 0x00, 255, 255, 255, 255);
gDPSetTextureLUT((*gfxPtr)++, G_TT_RGBA16); gDPSetTextureLUT((*gfxPtr)++, G_TT_RGBA16);
gDPLoadTLUT((*gfxPtr)++, 64, 256, gTextCharPalettes); gDPLoadTLUT((*gfxPtr)++, 64, 256, gTextCharPalettes);
#ifdef AVOID_UB
print = false;
#endif
// bug: if the for loop is skipped, print is never initialized // bug: if the for loop is skipped, print is never initialized
for (i = 0; msgPtr[i] != MSGCHAR_END && i < len; i++) { for (i = 0; msgPtr[i] != MSGCHAR_END && i < len; i++) {
print = false; print = false;
@ -158,8 +161,11 @@ void Message_DisplayScrollingText(Gfx** gfxPtr, u16* msgPtr, s32 xPos, s32 yPos,
bool Message_IsPrintingChar(u16* msgPtr, s32 charPos) { bool Message_IsPrintingChar(u16* msgPtr, s32 charPos) {
s32 i; s32 i;
s32 print; bool print;
#ifdef AVOID_UB
print = false;
#endif
// bug: if the for loop is skipped, print is never initialized // bug: if the for loop is skipped, print is never initialized
for (i = 0; msgPtr[i] != 0 && i < charPos; i++) { for (i = 0; msgPtr[i] != 0 && i < charPos; i++) {
print = false; print = false;