Fixed some weird casts

This commit is contained in:
KiritoDv 2024-04-18 15:06:13 -06:00 committed by Sonic Dreamcaster
parent a041298125
commit f71ebdca82
8 changed files with 39 additions and 33 deletions

View File

@ -46,6 +46,7 @@ endif()
# Set game compilation version # Set game compilation version
set(VERSION us) set(VERSION us)
set(USE_NETWORKING OFF) set(USE_NETWORKING OFF)
set(SKIP_XCODE_VERSION_CHECK ON)
# Add compile definitions for the target # Add compile definitions for the target
add_compile_definitions( add_compile_definitions(
@ -394,9 +395,11 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang")
-Wno-parentheses -Wno-parentheses
-Wno-narrowing -Wno-narrowing
-Wno-missing-braces -Wno-missing-braces
-Wno-int-conversion
$<$<COMPILE_LANGUAGE:C>: $<$<COMPILE_LANGUAGE:C>:
-Werror-implicit-function-declaration -Werror-implicit-function-declaration
-Wno-incompatible-pointer-types -Wno-incompatible-pointer-types
-fpermissive
> >
$<$<COMPILE_LANGUAGE:CXX>:-fpermissive> $<$<COMPILE_LANGUAGE:CXX>:-fpermissive>
$<$<COMPILE_LANGUAGE:CXX>: $<$<COMPILE_LANGUAGE:CXX>:
@ -420,9 +423,11 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang")
-Wno-parentheses -Wno-parentheses
-Wno-narrowing -Wno-narrowing
-Wno-missing-braces -Wno-missing-braces
-Wno-int-conversion
$<$<COMPILE_LANGUAGE:C>: $<$<COMPILE_LANGUAGE:C>:
-Werror-implicit-function-declaration -Werror-implicit-function-declaration
-Wno-incompatible-pointer-types -Wno-incompatible-pointer-types
-fpermissive
> >
$<$<COMPILE_LANGUAGE:CXX>:-fpermissive> $<$<COMPILE_LANGUAGE:CXX>:-fpermissive>
$<$<COMPILE_LANGUAGE:CXX>: $<$<COMPILE_LANGUAGE:CXX>:
@ -469,9 +474,11 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang")
-Wno-parentheses -Wno-parentheses
-Wno-narrowing -Wno-narrowing
-Wno-missing-braces -Wno-missing-braces
-Wno-int-conversion
$<$<COMPILE_LANGUAGE:C>: $<$<COMPILE_LANGUAGE:C>:
-Werror-implicit-function-declaration -Werror-implicit-function-declaration
-Wno-incompatible-pointer-types -Wno-incompatible-pointer-types
-fpermissive
> >
$<$<COMPILE_LANGUAGE:CXX>:-fpermissive> $<$<COMPILE_LANGUAGE:CXX>:-fpermissive>
$<$<COMPILE_LANGUAGE:CXX>:-Wno-deprecated-enum-enum-conversion> $<$<COMPILE_LANGUAGE:CXX>:-Wno-deprecated-enum-enum-conversion>

View File

@ -703,7 +703,7 @@ typedef struct {
/* 0x02 */ s8 sampleBankId; /* 0x02 */ s8 sampleBankId;
/* 0x03 */ char unk_03[0x5]; /* 0x03 */ char unk_03[0x5];
/* 0x08 */ u8* allocatedAddr; /* 0x08 */ u8* allocatedAddr;
/* 0x0C */ void* sampleAddr; /* 0x0C */ uintptr_t sampleAddr;
/* 0x10 */ u32 size; /* 0x10 */ u32 size;
} SampleCacheEntry; // size = 0x14 } SampleCacheEntry; // size = 0x14
@ -844,7 +844,7 @@ typedef struct {
typedef struct SampleDma { typedef struct SampleDma {
/* 0x00 */ u8* ramAddr; /* 0x00 */ u8* ramAddr;
/* 0x04 */ u32 devAddr; /* 0x04 */ uintptr_t devAddr;
/* 0x08 */ u16 sizeUnused; /* 0x08 */ u16 sizeUnused;
/* 0x0A */ u16 size; /* 0x0A */ u16 size;
/* 0x0C */ u8 unused; /* 0x0C */ u8 unused;
@ -1036,12 +1036,12 @@ void* AudioHeap_Alloc(AudioAllocPool* pool, u32 size);
void AudioHeap_InitPool(AudioAllocPool* pool, void* ramAddr, u32 size); void AudioHeap_InitPool(AudioAllocPool* pool, void* ramAddr, u32 size);
void AudioHeap_InitMainPools(s32 initPoolSize); void AudioHeap_InitMainPools(s32 initPoolSize);
void* AudioHeap_AllocCached(s32 tableType, s32 size, s32 cache, s32 id); void* AudioHeap_AllocCached(s32 tableType, s32 size, s32 cache, s32 id);
void* AudioHeap_SearchCaches(s32 tableType, s32 cache, s32 id); uintptr_t AudioHeap_SearchCaches(s32 tableType, s32 cache, s32 id);
s32 AudioHeap_ResetStep(void); s32 AudioHeap_ResetStep(void);
void* AudioHeap_SearchPermanentCache(s32 tableType, s32 id); void* AudioHeap_SearchPermanentCache(s32 tableType, s32 id);
u8* AudioHeap_AllocPermanent(s32 tableType, s32 id, u32 size); u8* AudioHeap_AllocPermanent(s32 tableType, s32 id, u32 size);
void* AudioHeap_AllocTemporarySampleCache(s32 size, s32 fontId, s32 sampleAddr, s8 medium); void* AudioHeap_AllocTemporarySampleCache(s32 size, s32 fontId, uintptr_t sampleAddr, s8 medium);
void* AudioHeap_AllocPersistentSampleCache(s32 size, s32 fontId, s32 sampleAddr, s8 medium); void* AudioHeap_AllocPersistentSampleCache(s32 size, s32 fontId, uintptr_t sampleAddr, s8 medium);
// audio_load // audio_load
void AudioLoad_DecreaseSampleDmaTtls(void); void AudioLoad_DecreaseSampleDmaTtls(void);

View File

@ -401,7 +401,7 @@ void* AudioHeap_AllocCached(s32 tableType, s32 size, s32 cache, s32 id) {
break; break;
case 1: case 1:
temporaryCache->entries[1].ramAddr = temporaryCache->entries[1].ramAddr =
(((u32) &temporaryPool->startRamAddr[temporaryPool->size] - size) & ~0xF); (u8*) ((uintptr_t) &temporaryPool->startRamAddr[temporaryPool->size] - size & ~0xF);
temporaryCache->entries[1].id = id; temporaryCache->entries[1].id = id;
temporaryCache->entries[1].size = size; temporaryCache->entries[1].size = size;
if ((temporaryCache->entries[0].id != -1) && if ((temporaryCache->entries[0].id != -1) &&
@ -442,18 +442,18 @@ void* AudioHeap_AllocCached(s32 tableType, s32 size, s32 cache, s32 id) {
return loadedCache->persistent.entries[loadedCache->persistent.numEntries++].ramAddr; return loadedCache->persistent.entries[loadedCache->persistent.numEntries++].ramAddr;
} }
void* AudioHeap_SearchCaches(s32 tableType, s32 cache, s32 id) { uintptr_t AudioHeap_SearchCaches(s32 tableType, s32 cache, s32 id) {
void* ramAddr; void* ramAddr;
// Always search the permanent cache in addition to the regular ones. // Always search the permanent cache in addition to the regular ones.
ramAddr = AudioHeap_SearchPermanentCache(tableType, id); ramAddr = AudioHeap_SearchPermanentCache(tableType, id);
if (ramAddr != NULL) { if (ramAddr != NULL) {
return ramAddr; return (uintptr_t) ramAddr;
} }
if (cache == CACHE_PERMANENT) { if (cache == CACHE_PERMANENT) {
return NULL; return (uintptr_t) NULL;
} }
return AudioHeap_SearchRegularCaches(tableType, cache, id); return (uintptr_t) AudioHeap_SearchRegularCaches(tableType, cache, id);
} }
void* AudioHeap_SearchRegularCaches(s32 tableType, s32 cache, s32 id) { void* AudioHeap_SearchRegularCaches(s32 tableType, s32 cache, s32 id) {
@ -497,7 +497,7 @@ void* AudioHeap_SearchRegularCaches(s32 tableType, s32 cache, s32 id) {
} }
if (cache == CACHE_EITHER) { if (cache == CACHE_EITHER) {
return AudioHeap_SearchCaches(tableType, CACHE_TEMPORARY, id); return (void*) AudioHeap_SearchCaches(tableType, CACHE_TEMPORARY, id);
} }
return NULL; return NULL;
} }
@ -778,7 +778,7 @@ u8* AudioHeap_AllocPermanent(s32 tableType, s32 id, u32 size) {
#endif #endif
} }
void* AudioHeap_AllocTemporarySampleCache(s32 size, s32 fontId, s32 sampleAddr, s8 medium) { void* AudioHeap_AllocTemporarySampleCache(s32 size, s32 fontId, uintptr_t sampleAddr, s8 medium) {
SampleCacheEntry* entry = AudioHeap_AllocTemporarySampleCacheEntry(size); SampleCacheEntry* entry = AudioHeap_AllocTemporarySampleCacheEntry(size);
if (entry != NULL) { if (entry != NULL) {
@ -791,7 +791,7 @@ void* AudioHeap_AllocTemporarySampleCache(s32 size, s32 fontId, s32 sampleAddr,
} }
} }
void* AudioHeap_AllocPersistentSampleCache(s32 size, s32 fontId, s32 sampleAddr, s8 medium) { void* AudioHeap_AllocPersistentSampleCache(s32 size, s32 fontId, uintptr_t sampleAddr, s8 medium) {
SampleCacheEntry* entry = AudioHeap_AllocPersistentSampleCacheEntry(size); SampleCacheEntry* entry = AudioHeap_AllocPersistentSampleCacheEntry(size);
if (entry != NULL) { if (entry != NULL) {
@ -920,10 +920,9 @@ void AudioHeap_DiscardSampleCacheEntry(SampleCacheEntry* entry) {
sampleBankId1 = gSoundFontList[fondId].sampleBankId1; sampleBankId1 = gSoundFontList[fondId].sampleBankId1;
sampleBankId2 = gSoundFontList[fondId].sampleBankId2; sampleBankId2 = gSoundFontList[fondId].sampleBankId2;
if (((sampleBankId1 != SAMPLES_NONE) && (entry->sampleBankId == sampleBankId1)) || if (((sampleBankId1 != SAMPLES_NONE) && (entry->sampleBankId == sampleBankId1)) ||
((sampleBankId2 != SAMPLES_NONE) && (entry->sampleBankId == sampleBankId2)) || ((sampleBankId2 != SAMPLES_NONE) && (entry->sampleBankId == sampleBankId2)) || (entry->sampleBankId == SAMPLES_SFX)) {
(entry->sampleBankId == SAMPLES_SFX)) { if (((void*) AudioHeap_SearchCaches(FONT_TABLE, CACHE_EITHER, fondId) != NULL) &&
if ((AudioHeap_SearchCaches(FONT_TABLE, CACHE_EITHER, fondId) != NULL) && (gFontLoadStatus[fondId] > 1) != 0) {
((gFontLoadStatus[fondId] > 1) != 0)) {
for (instId = 0; instId < gSoundFontList[fondId].numInstruments; instId++) { for (instId = 0; instId < gSoundFontList[fondId].numInstruments; instId++) {
instrument = Audio_GetInstrument(fondId, instId); instrument = Audio_GetInstrument(fondId, instId);
if (instrument != NULL) { if (instrument != NULL) {
@ -949,7 +948,7 @@ void AudioHeap_DiscardSampleCacheEntry(SampleCacheEntry* entry) {
void AudioHeap_UnapplySampleCache(SampleCacheEntry* entry, Sample* sample) { void AudioHeap_UnapplySampleCache(SampleCacheEntry* entry, Sample* sample) {
if ((sample != NULL) && (sample->sampleAddr == entry->allocatedAddr)) { if ((sample != NULL) && (sample->sampleAddr == entry->allocatedAddr)) {
sample->sampleAddr = entry->sampleAddr; sample->sampleAddr = (u8*) entry->sampleAddr;
sample->medium = entry->origMedium; sample->medium = entry->origMedium;
} }
} }
@ -994,7 +993,7 @@ void AudioHeap_DiscardSampleCaches(void) {
if (((sampleBankId1 != SAMPLES_NONE_U) && (entry->sampleBankId == sampleBankId1)) || if (((sampleBankId1 != SAMPLES_NONE_U) && (entry->sampleBankId == sampleBankId1)) ||
((sampleBankId2 != SAMPLES_NONE) && (entry->sampleBankId == sampleBankId2)) || ((sampleBankId2 != SAMPLES_NONE) && (entry->sampleBankId == sampleBankId2)) ||
(entry->sampleBankId == SAMPLES_SFX)) { (entry->sampleBankId == SAMPLES_SFX)) {
if ((AudioHeap_SearchCaches(FONT_TABLE, CACHE_PERMANENT, fontId) != NULL) && if (((void*) AudioHeap_SearchCaches(FONT_TABLE, CACHE_PERMANENT, fontId) != NULL) &&
((gFontLoadStatus[fontId] > 1) != 0)) { ((gFontLoadStatus[fontId] > 1) != 0)) {
for (i = 0; i < gPersistentSampleCache.numEntries; i++) { for (i = 0; i < gPersistentSampleCache.numEntries; i++) {
entry = &gPersistentSampleCache.entries[i]; entry = &gPersistentSampleCache.entries[i];

View File

@ -261,15 +261,15 @@ s32 AudioLoad_SyncLoadSample(Sample* sample, s32 fontId) {
u8* sampleAddr; u8* sampleAddr;
if ((sample->isRelocated == true) && (sample->medium != MEDIUM_RAM)) { if ((sample->isRelocated == true) && (sample->medium != MEDIUM_RAM)) {
sampleAddr = AudioHeap_AllocPersistentSampleCache(sample->size, fontId, sample->sampleAddr, sample->medium); sampleAddr = AudioHeap_AllocPersistentSampleCache(sample->size, fontId, (uintptr_t) sample->sampleAddr, sample->medium);
if (sampleAddr == NULL) { if (sampleAddr == NULL) {
return -1; return -1;
} }
if (sample->medium == MEDIUM_UNK) { if (sample->medium == MEDIUM_UNK) {
AudioLoad_SyncDmaUnkMedium(sample->sampleAddr, sampleAddr, sample->size, AudioLoad_SyncDmaUnkMedium((uintptr_t) sample->sampleAddr, sampleAddr, sample->size,
gSampleBankTable->base.unkMediumParam); gSampleBankTable->base.unkMediumParam);
} else { } else {
AudioLoad_SyncDma(sample->sampleAddr, sampleAddr, sample->size, sample->medium); AudioLoad_SyncDma((uintptr_t) sample->sampleAddr, sampleAddr, sample->size, sample->medium);
} }
sample->medium = MEDIUM_RAM; sample->medium = MEDIUM_RAM;
sample->sampleAddr = sampleAddr; sample->sampleAddr = sampleAddr;

View File

@ -268,7 +268,7 @@ void* func_800145FC(AudioListItem* list) {
list->prev = item->prev; list->prev = item->prev;
item->prev = NULL; item->prev = NULL;
list->u.count--; list->u.count--;
return item->u.count; return (void*) item->u.count;
} }
void func_8001463C(void) { void func_8001463C(void) {

View File

@ -578,7 +578,7 @@ u8* func_800097A8(Sample* sample, s32 length, u32 flags, UnkStruct_800097A8* arg
if (1) {} //! FAKE if (1) {} //! FAKE
sp1C->ttl = 2; sp1C->ttl = 2;
sp1C->devAddr = sample->sampleAddr; sp1C->devAddr = (uintptr_t) sample->sampleAddr;
sp1C->sizeUnused = length * 2; sp1C->sizeUnused = length * 2;
pad2 = arg3->unk_14; pad2 = arg3->unk_14;
pad2->ttl = 2; pad2->ttl = 2;

View File

@ -167,7 +167,7 @@ void AudioThread_ProcessGlobalCmd(AudioCmd* cmd) {
case AUDIOCMD_OP_GLOBAL_INIT_SEQPLAYER: case AUDIOCMD_OP_GLOBAL_INIT_SEQPLAYER:
case AUDIOCMD_OP_GLOBAL_INIT_SEQPLAYER_ALT: case AUDIOCMD_OP_GLOBAL_INIT_SEQPLAYER_ALT:
AudioLoad_SyncInitSeqPlayer(cmd->arg0, cmd->arg1, cmd->arg2); AudioLoad_SyncInitSeqPlayer(cmd->arg0, cmd->arg1, cmd->arg2);
AudioThread_SetFadeInTimer(cmd->arg0, cmd->data); AudioThread_SetFadeInTimer(cmd->arg0, (s32) cmd->data);
break; break;
case AUDIOCMD_OP_GLOBAL_DISABLE_SEQPLAYER: case AUDIOCMD_OP_GLOBAL_DISABLE_SEQPLAYER:
if (gSeqPlayers[cmd->arg0].enabled) { if (gSeqPlayers[cmd->arg0].enabled) {