From 40f71786f9c15a5303ca302bfd3a5fb15dba5f79 Mon Sep 17 00:00:00 2001
From: Zamitto <167933696+zamitto@users.noreply.github.com>
Date: Sun, 5 Jan 2025 13:58:40 -0300
Subject: [PATCH] feat: sonar suggestions

---
 src/main/services/achievements/get-game-achievement-data.ts | 2 +-
 src/main/services/achievements/merge-achievements.ts        | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/services/achievements/get-game-achievement-data.ts b/src/main/services/achievements/get-game-achievement-data.ts
index c4d5732a..b1a7476f 100644
--- a/src/main/services/achievements/get-game-achievement-data.ts
+++ b/src/main/services/achievements/get-game-achievement-data.ts
@@ -13,7 +13,7 @@ export const getGameAchievementData = async (
   shop: GameShop,
   cachedAchievements: GameAchievement | null
 ) => {
-  if (cachedAchievements && cachedAchievements.achievements) {
+  if (cachedAchievements?.achievements) {
     return JSON.parse(cachedAchievements.achievements) as AchievementData[];
   }
 
diff --git a/src/main/services/achievements/merge-achievements.ts b/src/main/services/achievements/merge-achievements.ts
index dd8c877d..61a444c5 100644
--- a/src/main/services/achievements/merge-achievements.ts
+++ b/src/main/services/achievements/merge-achievements.ts
@@ -64,7 +64,7 @@ export const mergeAchievements = async (
   ).filter((achievement) => achievement.name) as UnlockedAchievement[];
 
   const newAchievementsMap = new Map(
-    achievements.reverse().map((achievement) => {
+    achievements.toReversed().map((achievement) => {
       return [achievement.name.toUpperCase(), achievement];
     })
   );
@@ -92,7 +92,7 @@ export const mergeAchievements = async (
     userPreferences?.achievementNotificationsEnabled
   ) {
     const achievementsInfo = newAchievements
-      .sort((a, b) => {
+      .toSorted((a, b) => {
         return a.unlockTime - b.unlockTime;
       })
       .map((achievement) => {