PublicMirrors/hydra
1
0
Fork 0
mirror of https://github.com/hydralauncher/hydra.git synced 2025-01-23 21:44:55 +03:00
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #76 from fernandozanutto/fix/missing-useEffect-dependency

Browse Source 
fix: add handleCloseClick to useEffect dependency
This commit is contained in:
Hydra 2024-04-23 23:58:18 +01:00 committed by GitHub
commit 80f69f3600
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/renderer/components/modal/modal.tsx
View File

@ -1,4 +1,4 @@
import { useEffect, useId, useRef, useState } from "react";
import { useCallback, useEffect, useRef, useState } from "react";
import { createPortal } from "react-dom";
import { XIcon } from "@primer/octicons-react";
@ -24,9 +24,8 @@ export function Modal({
const [isClosing, setIsClosing] = useState(false);
const dispatch = useAppDispatch();
const modalContentRef = useRef<HTMLDivElement | null>(null);
const componentId = useId();
const handleCloseClick = () => {
const handleCloseClick = useCallback(() => {
setIsClosing(true);
const zero = performance.now();
@ -38,7 +37,7 @@ export function Modal({
setIsClosing(false);
}
});
};
}, [onClose]);
const isTopMostModal = () => {
const openModals = document.querySelectorAll("[role=modal]");
@ -57,7 +56,7 @@ export function Modal({
window.addEventListener("keydown", onKeyDown);
return () => window.removeEventListener("keydown", onKeyDown);
}, []);
}, [handleCloseClick]);
useEffect(() => {
const onMouseDown = (e: MouseEvent) => {
@ -74,7 +73,7 @@ export function Modal({
window.addEventListener("mousedown", onMouseDown);
return () => window.removeEventListener("mousedown", onMouseDown);
}, []);
}, [handleCloseClick]);
useEffect(() => {
dispatch(toggleDragging(visible));