From f1c37a0aafa895ab1807471e9ef7874c4ba8150f Mon Sep 17 00:00:00 2001 From: Zamitto Date: Wed, 1 May 2024 17:39:17 -0300 Subject: [PATCH] refactor updateLastTimePlayed, setInterval seems unnecessary --- .../src/pages/game-details/hero-panel.tsx | 26 ++++++------------- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/src/renderer/src/pages/game-details/hero-panel.tsx b/src/renderer/src/pages/game-details/hero-panel.tsx index cce85c4f..3fc4a4b3 100644 --- a/src/renderer/src/pages/game-details/hero-panel.tsx +++ b/src/renderer/src/pages/game-details/hero-panel.tsx @@ -1,5 +1,5 @@ import { format } from "date-fns"; -import { useCallback, useEffect, useMemo, useState } from "react"; +import { useEffect, useMemo, useState } from "react"; import { useTranslation } from "react-i18next"; import { useDownload } from "@renderer/hooks"; @@ -47,30 +47,20 @@ export function HeroPanel({ } = useDownload(); const isGameDownloading = isDownloading && gameDownloading?.id === game?.id; - const updateLastTimePlayed = useCallback(() => { - setLastTimePlayed( - formatDistance(game.lastTimePlayed, new Date(), { - addSuffix: true, - }) - ); - }, [game?.lastTimePlayed, formatDistance]); - useEffect(() => { if (game?.lastTimePlayed) { - updateLastTimePlayed(); + setLastTimePlayed( + formatDistance(game.lastTimePlayed, new Date(), { + addSuffix: true, + }) + ); + } + }, [game?.lastTimePlayed, formatDistance]); - const interval = setInterval(() => { - updateLastTimePlayed(); - }, 1000); const formatPlayTime = (milliseconds: number) => { const seconds = milliseconds / 1000 const minutes = seconds / 60 - return () => { - clearInterval(interval); - }; - } - }, [game?.lastTimePlayed, updateLastTimePlayed]); if (minutes < 120) { return minutes.toFixed(0) + " " + t("minutes") }