feat: sonar suggestions

This commit is contained in:
Zamitto 2025-01-05 13:58:40 -03:00
parent 901dcb676f
commit 40f71786f9
2 changed files with 3 additions and 3 deletions

View File

@ -13,7 +13,7 @@ export const getGameAchievementData = async (
shop: GameShop, shop: GameShop,
cachedAchievements: GameAchievement | null cachedAchievements: GameAchievement | null
) => { ) => {
if (cachedAchievements && cachedAchievements.achievements) { if (cachedAchievements?.achievements) {
return JSON.parse(cachedAchievements.achievements) as AchievementData[]; return JSON.parse(cachedAchievements.achievements) as AchievementData[];
} }

View File

@ -64,7 +64,7 @@ export const mergeAchievements = async (
).filter((achievement) => achievement.name) as UnlockedAchievement[]; ).filter((achievement) => achievement.name) as UnlockedAchievement[];
const newAchievementsMap = new Map( const newAchievementsMap = new Map(
achievements.reverse().map((achievement) => { achievements.toReversed().map((achievement) => {
return [achievement.name.toUpperCase(), achievement]; return [achievement.name.toUpperCase(), achievement];
}) })
); );
@ -92,7 +92,7 @@ export const mergeAchievements = async (
userPreferences?.achievementNotificationsEnabled userPreferences?.achievementNotificationsEnabled
) { ) {
const achievementsInfo = newAchievements const achievementsInfo = newAchievements
.sort((a, b) => { .toSorted((a, b) => {
return a.unlockTime - b.unlockTime; return a.unlockTime - b.unlockTime;
}) })
.map((achievement) => { .map((achievement) => {